Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add smart contract e2e tests #85

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

test: Add smart contract e2e tests #85

wants to merge 8 commits into from

Conversation

rachit77
Copy link
Contributor

Description

Add smart contract e2e tests using bats

@rachit77 rachit77 self-assigned this Sep 20, 2024
@rachit77 rachit77 changed the title Add smart contract e2e tests test: Add smart contract e2e tests Sep 20, 2024
@rachit77 rachit77 marked this pull request as ready for review September 20, 2024 19:50
vcastellm
vcastellm reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but all the assert_output looks too verbose, maybe if one works all work? then we can limit the assertion to just a few meesages?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

@joanestebanr joanestebanr Awaiting requested review from joanestebanr

@ToniRamirezM ToniRamirezM Awaiting requested review from ToniRamirezM

At least 2 approving reviews are required to merge this pull request.

Assignees

@rachit77 rachit77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachit77 @vcastellm