Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add smart contract e2e tests #85
test: Add smart contract e2e tests #85
Changes from 7 commits
bbe5ed1
337bd91
38d79db
76e5afc
c2a62e6
2b19636
70181e5
9da549f
f220f21
e528574
cf8f434
03ac2ed
42b882a
0c74333
4890634
962eab4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you simply use the
send_tx
function? Seems like we could spare a couple of lines of code. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
send_tx
function, there are a few redundant balance checks for the sender and receiver. These checks have already been verified in other test cases, so I decided it would be more efficient to skip them for subsequent transactions to avoid unnecessary repetition.WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like too much there are the balance checks in the
send_tx
, it should be extracted as a separate function IMO, and invoked only when needed (basically keeping these helper functions focused), but that's probably a separate topic...For now, I'm ok with this, but eventually, I would like never to call the
cast send
explicitly but rely on the helper function (because it has validations and error checks).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this for now, will refactor the part you suggested when we increase the scope e2e tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you simply use the
send_tx
function? Seems like we could spare a couple of lines of code. WDYT?