Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change behavior of ci when external pr raised #448

Merged
merged 4 commits into from
Jan 31, 2025
Merged

refactor: change behavior of ci when external pr raised #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbab7e5
refactor: change behavior of ci when external pr raised
jhkimqd Jan 22, 2025
0ef76ed
fix: change None to null in yml
jhkimqd Jan 31, 2025
08fea2e
Merge branch 'main' into jihwan/fix-remote-pr-ci
jhkimqd Jan 31, 2025
cf88a48
Merge branch 'main' into jihwan/fix-remote-pr-ci
jhkimqd Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/tests/agglayer-sp1-key.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ deployment_stages:
deploy_cdk_bridge_ui: false

args:
agglayer_prover_sp1_key: ""
agglayer_prover_sp1_key: null
agglayer_prover_network_url: https://rpc.production2.succinct.tools
zkevm_contracts_image: leovct/zkevm-contracts:v9.0.0-rc.5-pp-fork.12

consensus_contract_type: pessimistic
erigon_strict_mode: false
gas_token_enabled: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ jobs:
# Step to handle when the SP1_PRIVATE_KEY secret is available.
- name: Replace Agglayer SP1 Prover Key with Github Secrets
run: |
sed -i "s/agglayer_prover_sp1_key: \"\"/agglayer_prover_sp1_key: \"${{ secrets.SP1_PRIVATE_KEY }}\"/" ./.github/tests/agglayer-sp1-key.yml
sed -i "s/agglayer_prover_sp1_key: null/agglayer_prover_sp1_key: \"${{ secrets.SP1_PRIVATE_KEY }}\"/" ./.github/tests/agglayer-sp1-key.yml
# This step will only execute if the necessary secrets are available, preventing failures
# on pull requests from forked repositories.
if: ${{ env.agglayer_prover_sp1_key && env.agglayer_prover_sp1_key != '' }}
Expand Down
Loading