Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change behavior of ci when external pr raised #448

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

jhkimqd
Copy link
Collaborator

@jhkimqd jhkimqd commented Jan 22, 2025

Description

This PR aims to fix the CI behavior to handle github secrets for attach-additional-cdks action when a PR is raised from a fork.

The changes will however skip the deployment of a third PP network and the following bridge scenarios because the SP1 key will not be available.

@jhkimqd jhkimqd force-pushed the jihwan/fix-remote-pr-ci branch from 28698ae to dbab7e5 Compare January 22, 2025 09:40
@leovct
Copy link
Member

leovct commented Jan 23, 2025

This is what I see from my fork where the SP1 key is not set:

https://github.com/leovct/kurtosis-cdk/actions/runs/12809027341/job/35713008062
Screenshot 2025-01-23 at 16 25 53

In your fork, on this specific branch, it looks like the step is not failing anymore but I'm not sure if this is because of the fix or because the SP1 key is already set in your repo? Can you confirm it's not set?

https://github.com/jhkimqd/kurtosis-cdk/actions/runs/12905389279/job/35984470854

If it's not set than lgtm!

@jhkimqd
Copy link
Collaborator Author

jhkimqd commented Jan 31, 2025

Thanks for checking! I had the SP1 secret set, so I've removed my SP1 secret and reran the tests, and that particular step seems to be passing normally
https://github.com/jhkimqd/kurtosis-cdk/actions/runs/12905389279/job/36455734449

@jhkimqd jhkimqd marked this pull request as draft January 31, 2025 04:16
@jhkimqd
Copy link
Collaborator Author

jhkimqd commented Jan 31, 2025

It seems like the steps requiring sp1 key is being skipped successfully
https://github.com/0xPolygon/kurtosis-cdk/actions/runs/13066519637/job/36459720972

image

@jhkimqd jhkimqd marked this pull request as ready for review January 31, 2025 04:50
@jhkimqd jhkimqd enabled auto-merge January 31, 2025 13:29
@jhkimqd jhkimqd merged commit f8d9e68 into 0xPolygon:main Jan 31, 2025
27 checks passed
@jhkimqd jhkimqd deleted the jihwan/fix-remote-pr-ci branch January 31, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants