Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit relayer flag for IBFT consensus #1971

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Oct 9, 2023

Description

This PR provides a relayer flag to cluster and docker scripts (polygon-edge.sh) only in case polybft consensus is being run.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Docker environment

  1. Run make run-docker
  2. Make sure polybft is working and blocks are being produced

Starting nodes from binary

  1. Run ./scripts/cluster polybft write-logs
  2. Make sure polybft is working and blocks are being produced

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal changed the title Remove copy core-contracts repo in Docker Fix local deployment scripts Oct 9, 2023
@Stefan-Ethernal Stefan-Ethernal mentioned this pull request Oct 9, 2023
11 tasks
@Stefan-Ethernal Stefan-Ethernal self-assigned this Oct 9, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/1926-docker-compose-ibft-consensus-failed-to-run-the-relayer-node branch 3 times, most recently from 98ebde3 to 8e527d6 Compare October 10, 2023 15:04
@Stefan-Ethernal Stefan-Ethernal requested review from a team and begmaroman October 10, 2023 15:25
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Oct 10, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review October 10, 2023 15:25
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/1926-docker-compose-ibft-consensus-failed-to-run-the-relayer-node branch from 30bebd8 to 1f6073c Compare October 11, 2023 07:33
@Stefan-Ethernal Stefan-Ethernal changed the title Fix local deployment scripts Omit relayer flag for IBFT consensus Oct 12, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 12, 2023 13:50
@Stefan-Ethernal Stefan-Ethernal merged commit b05e5e7 into develop Oct 12, 2023
6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/1926-docker-compose-ibft-consensus-failed-to-run-the-relayer-node branch October 12, 2023 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docker compose] : ibft consensus failed to run the relayer node
4 participants