Consolidate transaction inputs and outputs in dedicated modules #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
force-pushed
the
bobbin-tx-io
branch
from
d84f4b5
to
0a29e02
Compare
bobbinth
force-pushed
the
bobbin-tx-io
branch
from
1687b3f
to
dc02894
Compare
igamigo
approved these changes
Dec 28, 2023
Move transaction output parsing to `miden-lib`
Refactor `ProvenTransaction` to reduce code duplication
Reorganize `miden-lib` modules
Move transaction `AdviceInput` construction logic to `miden-lib`
Replace `TransactionResult` with `ExecutedTransaction`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #384.
This PR consolidates and renames transaction input and output structs (along the lines of what is described in #350). The main changes are:
RecordedNoterenamed intoInputNoteand moved totransactionmodule.ConsumedNotesrenamed intoInputNotesand updated interfaces a little.NoteStubrenamed intoOutputNoteand moved totransactionmodule.CreatedNotesrenamed intoOutputNotesand updated interfaces a little.FinalAccountStubstruct.TransactionOutputsstruct.ExecutedTransaction,PreparedTransaction, andTransactionResultto useTransactionInputsandTransactionOutputsstructs.This does not yet complete the refactoring - I will need to complete other things mentioned in #350 and also clean up transaction objects a bit more. But since this PR is already quite big, I'll do these in a follow-up PR.