Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved MAX_NUM_FOREIGN_ACCOUNTS into miden-objects #904

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Moved MAX_NUM_FOREIGN_ACCOUNTS into miden-objects #904

merged 2 commits into from
Oct 2, 2024

Conversation

polydez
Copy link
Contributor

@polydez polydez commented Oct 2, 2024

We decided to move this constant into miden-base during review: 0xPolygonMiden/miden-node#506 (comment)

@polydez polydez requested a review from bobbinth October 2, 2024 06:45
@polydez polydez marked this pull request as ready for review October 2, 2024 06:47
@polydez polydez mentioned this pull request Oct 2, 2024
Merged
bobbinth
bobbinth approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@polydez polydez merged commit 9dc06d7 into next Oct 2, 2024
7 checks passed
@polydez polydez deleted the polydez-max-acc-const branch October 2, 2024 06:49
@bobbinth bobbinth mentioned this pull request Oct 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polydez @bobbinth