Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved MAX_NUM_FOREIGN_ACCOUNTS into miden-objects #904

Merged
merged 2 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- [BREAKING] `send_asset` procedure was removed from the basic wallet (#829).
- [BREAKING] Updated limits, introduced additional limits (#889).
- Introduced `AccountDelta` maximum size limit of 32 KiB (#889).
- [BREAKING] Moved `MAX_NUM_FOREIGN_ACCOUNTS` into `miden-objects` (#904).

## 0.5.1 (2024-08-28) - `miden-objects` crate only

Expand Down
3 changes: 0 additions & 3 deletions miden-lib/src/transaction/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,6 @@ pub const KERNEL_PROCEDURES_PTR: MemoryAddress = 401;
// ACCOUNT DATA
// ------------------------------------------------------------------------------------------------

/// Maximum number of the foreign accounts that can be loaded.
pub const MAX_NUM_FOREIGN_ACCOUNTS: u8 = 64;

/// The size of the memory segment allocated to core account data (excluding new code commitment)
pub const ACCT_DATA_MEM_SIZE: MemSize = 4;

Expand Down
3 changes: 3 additions & 0 deletions objects/src/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ pub const MAX_TX_EXECUTION_CYCLES: u32 = 1 << 30;
/// The minimum number of VM cycles a transaction needs to execute.
pub const MIN_TX_EXECUTION_CYCLES: u32 = 1 << 12;

/// Maximum number of the foreign accounts that can be loaded.
pub const MAX_NUM_FOREIGN_ACCOUNTS: u8 = 64;

// TRANSACTION BATCH
// ================================================================================================

Expand Down
Loading