Fix bug in chiplet bus

[Al-Kindi-0]

Describe your changes

Fixes a couple of bugs in the auxiliary column for the chiplet's bus.

Checklist before requesting a review

• Repo forked and branch created from next according to naming convention.
• Commit messages and codestyle follow conventions.
• Relevant issues are linked in the PR description.
• Tests added for new functionality.
• Documentation/comments updated according to changes.

[bobbinth]

As discussed offline, I think the handling of the DYN operation here was correct. Which means there is a bug somewhere else - probably here where we shouldn't be putting dyn_hash into decoder registers (or at least that would be consistent with the current docs).

[plafer]

Pushed a commit that fixes this as explained here. Basically DYN emits a request to hash [ZERO; 8] using the DYN domain, which is verified on END. The block hash table is responsible for ensuring that the correct hash is being executed: the callee hash is pushed on the table on DYN, and removed on the appropriate END (when the callee terminates).

[plafer]

It seems like DYN could not issue any hash request, and also not have an associated END, since we're only hashing dummy values? So DYN would still populate the block hash table, but have no other effect on the trace.

[bobbinth]

It seems like DYN could not issue any hash request, and also not have an associated END, since we're only hashing dummy values? So DYN would still populate the block hash table, but have no other effect on the trace.

Yeah - I think that's correct.

[plafer]

LGTM! Thank you for fixing this!!

Also pushed a commit fixing how DYN works, make sure to double check that.

[bobbinth]

Looks good! Thank you!