Update JS release script to correctly sets package jsons #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the
release.sh
script to update thepackage.json
in theexamples
folder as well as theclient
folder.The command
npm pkg set
is not coupled with npm's registry so we can use this command to set it to any value we want without relying if it has been updated on NPM.I still kept the
wait_for_npm_publish
function to ensure that we still wait for npm to publish before we set it to its correct value as a safety.To Test
You can comment out the script but the increment parts and you can update the
version.ts
to any version and try running thenpm run release-stable
script. Thepackage.json
should be updated with whatever version you updated to.