Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS release script to correctly sets package jsons #124

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

MOmarMiraj
Copy link
Contributor

This PR will update the release.sh script to update the package.json in the examples folder as well as the client folder.

The command npm pkg set is not coupled with npm's registry so we can use this command to set it to any value we want without relying if it has been updated on NPM.

I still kept the wait_for_npm_publish function to ensure that we still wait for npm to publish before we set it to its correct value as a safety.

To Test

You can comment out the script but the increment parts and you can update the version.ts to any version and try running the npm run release-stable script. The package.json should be updated with whatever version you updated to.

@MOmarMiraj MOmarMiraj requested a review from hculea January 29, 2025 22:59
@MOmarMiraj MOmarMiraj self-assigned this Jan 29, 2025
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MOmarMiraj MOmarMiraj merged commit a1fff37 into main Jan 30, 2025
14 checks passed
@MOmarMiraj MOmarMiraj deleted the omar/fix-js-release-script branch January 30, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants