Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS release script to correctly sets package jsons #124

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions client/release/scripts/release.sh
Original file line number Diff line number Diff line change
@@ -88,8 +88,8 @@ fi
if [ "$core_modified" = true ]; then
# Wait for npm to be update to the latest version
wait_for_npm_publish @1password/sdk-core "${version_sdk_core}"
# Update @1password/sdk-core dependancy to the latest
npm install @1password/sdk-core@latest -E
# Set the package version regardless if npm published or not
npm pkg set dependencies.@1password/sdk-core="${version_sdk_core}"
fi

# Update sdk version number to the latest
@@ -109,8 +109,8 @@ fi

# Wait for npm to be update to the latest version
wait_for_npm_publish @1password/sdk "${version_sdk}"
# Update dependency in examples to run off the latest SDK
cd ../examples && npm install @1password/sdk@latest -E
# Set the package version regardless if npm published or not
cd ../examples && npm pkg set dependencies.@1password/sdk="${version_sdk}"

# Check if the latest SDK client is pulled correctly
cd ../ && npm install