Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Follow pathing and walk triggers behave closer to pre-2007 behavior #1238

Merged
merged 6 commits into from
Feb 9, 2025

Conversation

mark-b5
Copy link
Contributor

@mark-b5 mark-b5 commented Feb 9, 2025

Following a player before 2007 was pid dependent. With this PR, behavior should now match pre-2007 behavior.

Further, there were some bugs with how walktriggers are handled. They should now more accurately match expected behavior

Follow Example 1

When following a player, it should be pid-dependent whether or not you follow two tiles or three tiles back

In this video from 2006, we see that the players clearly get separated into two distinct groups based on pid

image

New 2004scape behavior

2025-02-08.20-29-20.mp4

With this PR, 2004scape now correctly sorts following players into two groups depending on pid. This should be the expected behavior.

Follow Example 2

Before 2023 in OSRS and pre-OSRS, if a player teleported away while you were following them, you would continue following them. In the previous 2004scape iteration, it clears your follow interaction if the player is no longer within 25 tiles of you. This is not how it should behave.

Old 2004scape Behavior

2025-02-08.20-58-47.mp4

New 2004scape Behavior

2025-02-08.20-58-06.mp4

Follow Example 3

New 2004scape behavior

2025-02-08.20-16-53.mp4

This follow dance wasn't possible in the previous iteration

In this video you can see two players performing this follow dance

image

Walktrigger Example 1

Previously, stuns were not correctly clearing the follow interaction in certain edge cases. Further, walktriggers are now handled more appropriately in general.

Previous 2004scape behavior

2025-02-08_00-32-18.mp4

Before this PR, if you were stunned and next to a player, you would run the stun walktrigger every tick. The expected behavior is that you clear the follow interaction because you are stunned

New 2004scape behavior

2025-02-08.20-35-36.mp4

Now the stun walktrigger runs a single time and then appropriately clears the follow interaction

@Pazaz Pazaz merged commit a92b2ee into 2004Scape:main Feb 9, 2025
4 checks passed
Pazaz added a commit that referenced this pull request Feb 10, 2025
## Content Changes

### Features

* #1099

### Fixes

* #1203
* #1223
* #1234
* #1236
* #1242
* #1243
* #1244
* #1245
* #1247

## Engine Changes

### Features

* #1237
* Login server abuse protection

### Fixes

* #1233
* #1235
* #1238
* #1240
* #1241
* #1249
* Obj command validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants