basehub: update jupyterhub chart from 3.2.1 to 3.3.7 (Scheduled for 9nd April) #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
z2jh 3.3.0 is broken because pycurl is broken due to a regression in a patch release, working to fix it now. EDIT: we are bumping to z2jh 3.3.1 instead now. |
consideRatio
changed the title
yuvipanda
approved these changes
Mar 20, 2024
consideRatio
changed the title
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
from
6b4af3b to
616fc97
Compare
|
Okay, two z2jh patch releases later things work it seems! Will merge tomorrow when I'm starting my workday. Thank you for reviewing this @yuvipanda!! |
|
@yuvipanda I'm getting pulled into needing to understand how jupyterhub-configurator works etc since its broken against jupyterhub 4.1.0 - likely due to CORS related changes. I'd like to bite the bullet and catch up with misc maintenance:
Are you OK with granting me maintainer rights and going for it quite swiftly? |
|
@consideRatio I've added you as maintainer. However, there are no users of that outside of 2i2c (especially after it was taken out of tljh), and it is an architectural dead end. I think it's ok to do the work that unblocks z2jh upgrades, but i don't think it should have any other work done on it at all. I've closed or merged PRs as appropriate. |
|
I'd also think it's appropriate to rollback |
consideRatio
changed the title
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
2 times, most recently
from
7e05c14 to
6a7121c
Compare
yuvipanda
requested changes
Mar 25, 2024
consideRatio
changed the title
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
from
6a7121c to
4e62f66
Compare
|
I'm planning this to be deployed next tuesday - 2nd April. |
consideRatio
changed the title
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
2 times, most recently
from
5c951e8 to
144d367
Compare
|
@yuvipanda I've verified that a server-side change doesn't cause issues in any of the things you listed. Beyond this because its related, I've considered the user environments. I've concluded that jupyterhub 4.1.4, nbgitpuller 1.2.1, and jupyter-remote-desktop-proxy 2.0.0, jupyter-resource-usage 1.0.2 (no patch needed), and utoronto's classical UI from notebook 6, Lab UI, and RStudio UI works when jupyterhub-singleuser 4.1.4 is used in the user environment - use of jupyterhub 4.0 or 4.1 server side doesn't change this.
OK to ship today? The option to this is next week if I'm to take responsibility and monitor this change without entering too much non-working hours. |
|
@consideRatio thanks for doing that. My suggestion is to do this next week, given we still have a bunch of things that we had committed to this sprint not done yet. We can schedule this during the sprint planning meeting for the next one. |
consideRatio
changed the title
|
@yuvipanda rescheduled to 9th april! |
|
Ask @GeorgianaElena to spend some cycles on this one next week. |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Apr 5, 2024
The Auth0 authenticator made the EarthScope authentication mechanism look more custom than it really was - it's really just standard auth0, and if you look at the [auth0 authenticator](https://github.com/jupyterhub/oauthenticator/blob/main/oauthenticator/auth0.py) code it's fairly minimal - just a couple of convenience functions. This PR switches that (+ our auth0 documentation) to simply use GenericOAuthenticator. This has the following advantages: 1. The Auth0 documentation we have can be easily ported to just support any Generic OAuth provider if needed in the future. 2. The GenericOAuthenticator has features the Auth0 one does not - particularly around groups management that we do want to use. While eventually I think this should be made available to all authenticators (and will work with upstream in doing so), moving to GenericOAuthenticator unblocks planning & scheduling engineering work here as soon as 2i2c-org#3818 is merged. 3. It signals that the EarthScope hub is not *that* special, just the first as a way for us to develop and offer new features. We should work on structuring how we do this, and signal when features are available in what hubs. But in the meantime, this reduces the overall apparent complexity to match actual complexity 4. Removes the custom logout_url work, and instead just mentions you need to set the `client_id` in the logout_url, and adds that to our auth0 documentation. This removes more custom code we have for EarthScope. Once jupyterhub/oauthenticator#719 is merged, this helps us remove all custom code here from earthscope. This part fixes 2i2c-org#3715 This was triggered as cleanup by https://2i2c.freshdesk.com/a/tickets/1453. I'll create appropriate issues for next steps, and will prioritize any future work accordingly with our engineering processes.
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
from
73678d8 to
2e64459
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
from
2e64459 to
3967b20
Compare
consideRatio
force-pushed
the
pr/bump-to-z2jh-3.3.0
branch
from
3967b20 to
f5d5f73
Compare
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8613587954 |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Apr 30, 2024
The Auth0 authenticator made the EarthScope authentication mechanism look more custom than it really was - it's really just standard auth0, and if you look at the [auth0 authenticator](https://github.com/jupyterhub/oauthenticator/blob/main/oauthenticator/auth0.py) code it's fairly minimal - just a couple of convenience functions. This PR switches that (+ our auth0 documentation) to simply use GenericOAuthenticator. This has the following advantages: 1. The Auth0 documentation we have can be easily ported to just support any Generic OAuth provider if needed in the future. 2. The GenericOAuthenticator has features the Auth0 one does not - particularly around groups management that we do want to use. While eventually I think this should be made available to all authenticators (and will work with upstream in doing so), moving to GenericOAuthenticator unblocks planning & scheduling engineering work here as soon as 2i2c-org#3818 is merged. 3. It signals that the EarthScope hub is not *that* special, just the first as a way for us to develop and offer new features. We should work on structuring how we do this, and signal when features are available in what hubs. But in the meantime, this reduces the overall apparent complexity to match actual complexity 4. Removes the custom logout_url work, and instead just mentions you need to set the `client_id` in the logout_url, and adds that to our auth0 documentation. This removes more custom code we have for EarthScope. Once jupyterhub/oauthenticator#719 is merged, this helps us remove all custom code here from earthscope. This part fixes 2i2c-org#3715 This was triggered as cleanup by https://2i2c.freshdesk.com/a/tickets/1453. I'll create appropriate issues for next steps, and will prioritize any future work accordingly with our engineering processes.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 3, 2024
The Auth0 authenticator made the EarthScope authentication mechanism look more custom than it really was - it's really just standard auth0, and if you look at the [auth0 authenticator](https://github.com/jupyterhub/oauthenticator/blob/main/oauthenticator/auth0.py) code it's fairly minimal - just a couple of convenience functions. This PR switches that (+ our auth0 documentation) to simply use GenericOAuthenticator. This has the following advantages: 1. The Auth0 documentation we have can be easily ported to just support any Generic OAuth provider if needed in the future. 2. The GenericOAuthenticator has features the Auth0 one does not - particularly around groups management that we do want to use. While eventually I think this should be made available to all authenticators (and will work with upstream in doing so), moving to GenericOAuthenticator unblocks planning & scheduling engineering work here as soon as 2i2c-org#3818 is merged. 3. It signals that the EarthScope hub is not *that* special, just the first as a way for us to develop and offer new features. We should work on structuring how we do this, and signal when features are available in what hubs. But in the meantime, this reduces the overall apparent complexity to match actual complexity 4. Removes the custom logout_url work, and instead just mentions you need to set the `client_id` in the logout_url, and adds that to our auth0 documentation. This removes more custom code we have for EarthScope. Once jupyterhub/oauthenticator#719 is merged, this helps us remove all custom code here from earthscope. This part fixes 2i2c-org#3715 This was triggered as cleanup by https://2i2c.freshdesk.com/a/tickets/1453. I'll create appropriate issues for next steps, and will prioritize any future work accordingly with our engineering processes.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 7, 2024
The Auth0 authenticator made the EarthScope authentication mechanism look more custom than it really was - it's really just standard auth0, and if you look at the [auth0 authenticator](https://github.com/jupyterhub/oauthenticator/blob/main/oauthenticator/auth0.py) code it's fairly minimal - just a couple of convenience functions. This PR switches that (+ our auth0 documentation) to simply use GenericOAuthenticator. This has the following advantages: 1. The Auth0 documentation we have can be easily ported to just support any Generic OAuth provider if needed in the future. 2. The GenericOAuthenticator has features the Auth0 one does not - particularly around groups management that we do want to use. While eventually I think this should be made available to all authenticators (and will work with upstream in doing so), moving to GenericOAuthenticator unblocks planning & scheduling engineering work here as soon as 2i2c-org#3818 is merged. 3. It signals that the EarthScope hub is not *that* special, just the first as a way for us to develop and offer new features. We should work on structuring how we do this, and signal when features are available in what hubs. But in the meantime, this reduces the overall apparent complexity to match actual complexity 4. Removes the custom logout_url work, and instead just mentions you need to set the `client_id` in the logout_url, and adds that to our auth0 documentation. This removes more custom code we have for EarthScope. Once jupyterhub/oauthenticator#719 is merged, this helps us remove all custom code here from earthscope. This part fixes 2i2c-org#3715 This was triggered as cleanup by https://2i2c.freshdesk.com/a/tickets/1453. I'll create appropriate issues for next steps, and will prioritize any future work accordingly with our engineering processes.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 7, 2024
The Auth0 authenticator made the EarthScope authentication mechanism look more custom than it really was - it's really just standard auth0, and if you look at the [auth0 authenticator](https://github.com/jupyterhub/oauthenticator/blob/main/oauthenticator/auth0.py) code it's fairly minimal - just a couple of convenience functions. This PR switches that (+ our auth0 documentation) to simply use GenericOAuthenticator. This has the following advantages: 1. The Auth0 documentation we have can be easily ported to just support any Generic OAuth provider if needed in the future. 2. The GenericOAuthenticator has features the Auth0 one does not - particularly around groups management that we do want to use. While eventually I think this should be made available to all authenticators (and will work with upstream in doing so), moving to GenericOAuthenticator unblocks planning & scheduling engineering work here as soon as 2i2c-org#3818 is merged. 3. It signals that the EarthScope hub is not *that* special, just the first as a way for us to develop and offer new features. We should work on structuring how we do this, and signal when features are available in what hubs. But in the meantime, this reduces the overall apparent complexity to match actual complexity 4. Removes the custom logout_url work, and instead just mentions you need to set the `client_id` in the logout_url, and adds that to our auth0 documentation. This removes more custom code we have for EarthScope. Once jupyterhub/oauthenticator#719 is merged, this helps us remove all custom code here from earthscope. This part fixes 2i2c-org#3715 This was triggered as cleanup by https://2i2c.freshdesk.com/a/tickets/1453. I'll create appropriate issues for next steps, and will prioritize any future work accordingly with our engineering processes.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 7, 2024
The Auth0 authenticator made the EarthScope authentication mechanism look more custom than it really was - it's really just standard auth0, and if you look at the [auth0 authenticator](https://github.com/jupyterhub/oauthenticator/blob/main/oauthenticator/auth0.py) code it's fairly minimal - just a couple of convenience functions. This PR switches that (+ our auth0 documentation) to simply use GenericOAuthenticator. This has the following advantages: 1. The Auth0 documentation we have can be easily ported to just support any Generic OAuth provider if needed in the future. 2. The GenericOAuthenticator has features the Auth0 one does not - particularly around groups management that we do want to use. While eventually I think this should be made available to all authenticators (and will work with upstream in doing so), moving to GenericOAuthenticator unblocks planning & scheduling engineering work here as soon as 2i2c-org#3818 is merged. 3. It signals that the EarthScope hub is not *that* special, just the first as a way for us to develop and offer new features. We should work on structuring how we do this, and signal when features are available in what hubs. But in the meantime, this reduces the overall apparent complexity to match actual complexity 4. Removes the custom logout_url work, and instead just mentions you need to set the `client_id` in the logout_url, and adds that to our auth0 documentation. This removes more custom code we have for EarthScope. Once jupyterhub/oauthenticator#719 is merged, this helps us remove all custom code here from earthscope. This part fixes 2i2c-org#3715 This was triggered as cleanup by https://2i2c.freshdesk.com/a/tickets/1453. I'll create appropriate issues for next steps, and will prioritize any future work accordingly with our engineering processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update brings in jupyterhub 4.1.0 and oauthenticator 16.3.0.
Two bugfixes upstream
This early adoption of z2jh's new release led to catching two bugs.
Z2JH 3.3.0 is broken - pycurl issues with certificates jupyterhub/zero-to-jupyterhub-k8s#3366
Regression for
singleuser.cloudMetadata.blockWithIptablesin z2jh 3.3.0 and 3.3.1 - workaround in 3.3.2 jupyterhub/zero-to-jupyterhub-k8s#3368Compatibility fix in jupyterhub-configurator
About JupyterHub 4.1.1 - 4.1.5 releases
Several (all?) of the issues patched related to
jupyterhubcode executed in the user servers, which are unaffected by this PRs upgrade of the server side part of jupyterhub.Verifications
Related