fix(streak-count): Fix streak count calculation #28
Conversation
- count will no longer be store in user.streaks, but will be calculated on the fly. - Update streakUtils to calculate streak count on the fly. - Update Streak component to use streakUtils to calculate streak count. - Update test accordingly. - Update UserContext'a type declaration accordingly.
ZL-Asica
force-pushed
the
fix/streak-count
branch
from
5d029e3 to
4bef153
Compare
|
🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-28-25p915uh.web.app 🧪 Test Results✅ Tests Passed: All tests passed successfully! 🎨 Prettier Format Check✅ Prettier: No formatting issues found! 🎨 Lint Check✅ Lint: No linting issues found! |
|
🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-28-25p915uh.web.app 🧪 Test Results❌ Some tests failed: 💥 Please review the failed tests above. 🎨 Prettier Format Check✅ Prettier: No formatting issues found! 🎨 Lint Check✅ Lint: No linting issues found! |
|
🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-28-25p915uh.web.app 🧪 Test Results✅ Tests Passed: All tests passed successfully! 🎨 Prettier Format Check✅ Prettier: No formatting issues found! 🎨 Lint Check✅ Lint: No linting issues found! |
ZL-Asica
force-pushed
the
fix/streak-count
branch
from
7f9e3b2 to
84ad619
Compare
|
🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-28-25p915uh.web.app 🧪 Test Results✅ Tests Passed: All tests passed successfully! 🎨 Prettier Format Check✅ Prettier: No formatting issues found! 🎨 Lint Check✅ Lint: No linting issues found! |
- Count and todayCount will update at every time fetching user profile. - Updates with task completion toggled. - Update Home.test.jsx to fully mock the UserContext to improve speed.
|
🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-28-25p915uh.web.app 🧪 Test Results✅ Tests Passed: All tests passed successfully! 🎨 Prettier Format Check✅ Prettier: No formatting issues found! 🎨 Lint Check✅ Lint: No linting issues found! |
countandtodayCountwill update every time fetching user profile.Update
streakUtilsto calculate streak count based on continuous logic (if a day does not have a count, the streak will loss).Update test accordingly.
Update UserContext'a type declaration accordingly.