This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Add categories for mixin list in right panel #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far I have made it without a design from Figma. I will add styles in the next commit.
For this PR to work, first need to apply changes from this PR: 3DStreet/3dstreet#418
So that information about mixin groups is stored in the attribute of street-assets element.
This is version 1. But I decided to implement the mixin grouping differently. I will store the category name in the
category
attribute for each mixin.We can also take the group name from the html comments, but this is unreliable for the future.
@kfarr Maybe you will comment also which option is better for your opinion?