Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Add categories for mixin list in right panel #354

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

Algorush
Copy link
Collaborator

@Algorush Algorush commented Nov 27, 2023

So far I have made it without a design from Figma. I will add styles in the next commit.
For this PR to work, first need to apply changes from this PR: 3DStreet/3dstreet#418
So that information about mixin groups is stored in the attribute of street-assets element.
This is version 1. But I decided to implement the mixin grouping differently. I will store the category name in the category attribute for each mixin.
We can also take the group name from the html comments, but this is unreliable for the future.
@kfarr Maybe you will comment also which option is better for your opinion?

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
🔨 Latest commit 113d10a
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/65f128782ebe550008e1763c
😎 Deploy Preview https://deploy-preview-354--3dstreet-editor-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Algorush
Copy link
Collaborator Author

Algorush commented Nov 28, 2023

Added new commit to this PR and to PR in 3DStreet repo: 3DStreet/3dstreet#418. Now I have changed the way category names are stored, now they are stored in the category attribute for each mixin. And the function for creating groups in the mixin component has also been changed

@kfarr
Copy link
Contributor

kfarr commented Mar 13, 2024

this works really well! thanks @Algorush

@kfarr kfarr merged commit a99d725 into master Mar 13, 2024
@kfarr kfarr deleted the mixin-categories-in-right-panel branch March 13, 2024 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants