Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save grouped assets in the attribute of street-assets element #418

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

Algorush
Copy link
Collaborator

This function is needed to display mixins categories in the mixin list in the editor. To make this PR work: 3DStreet/3dstreet-editor#354

add categories attribute to each mixin instead of storing the list of mixins in one attribute
@Algorush
Copy link
Collaborator Author

I added commit with changes. The mixin category is now stored in the category attribute fro each mixin. Instead of storing a list of mixins in one attribute of street-assets element.

@kfarr kfarr changed the base branch from creator-usability-epic-v1 to main December 9, 2023 05:27
Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for 3dstreet-core-builds ready!

Name Link
🔨 Latest commit 03c58b3
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-core-builds/deploys/6574009d39fe4a00088600a1
😎 Deploy Preview https://deploy-preview-418--3dstreet-core-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfarr
Copy link
Collaborator

kfarr commented Dec 9, 2023

I tested this only to make sure it doesn't break anything else. Once this is released on core then we can test on editor.

@kfarr kfarr merged commit e355720 into main Dec 9, 2023
6 checks passed
@kfarr kfarr deleted the save-assets-categories branch December 9, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants