-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use A-Frame anisotropy instead of 3dstreet custom component #325
Conversation
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
please modify /index.html instead of adding a new file /src/index.html also please ensure you have found all instances of "anisotropy" in assets.js, there appear to be a few still there also make sure to remove the anisotropy.js file from the repo as well as removing any require or import statements that reference the component |
working but requires master aframe
merged this instead: #332 |
Description
This PR addresses the issue #315 by replacing the custom anisotropy component in the codebase with the built-in anisotropy feature of A-Frame. The changes involve modifying the
index.html
renderer, removing theanisotropy.js
component, and removing any instances of anisotropy application in theassets.js
file.Summary of Changes
src/index.html
to add therenderer="anisotropy: 16"
attribute to set the anisotropy for the entire scene.src/components/anisotropy.js
file, as the anisotropy feature is now built into A-Frame.src/assets.js
file to ensure consistency with the new implementation.Please review and merge this PR. Thank you!
Fixes #315.
To checkout this PR branch, run the following command in your terminal:
To make tweaks to this pull request, leave a comment below or in the code.