obb clipping

[kfarr]

barely working v1

enable by pasting into console after loading a scene into editor with google3d tiles layer:

document.querySelector('#clipping-box').setAttribute('obb-collider2', "clipPlaneFunction: obb;"); 
document.querySelector('#clipping-box').play();

video:
https://github.com/user-attachments/assets/b29a31aa-d312-42b0-b87a-15988f23d775

some things this needs:

• see the other branch on how make the component usable as a boolean option in street geo component, instead of copy/paste console code --> when street-geo sets clipping ON, then the box is created with this component on it
• rename to 'obb-clipping' (component and system)
• try setting the "known good" clipping box to be the same dimensions as the default street in the scene
• try moving the box to a child layer and/or adding obb-collider2 component to the underground box entity itself
• try moving obb-collider2 component to the 3dtiles itself using trackedObject3D property to reference the box
• try removing top/bottom planes to have infinite top/bottom
• once we figure out the right mechanism to allow the user to save the clipping settings, ensure it saves/loads correctly

[rahulkgupta]

the math in this makes my head spin

[rahulkgupta]

What's the other branch?

[kfarr]

What's the other branch?

#877

[kfarr]

next steps:

• test if I can put the component on the street underground box instead of a root box

[kfarr]

barely working 3

barely-working-clipping3.mov

issues to fix:

• data-no-pause doesn't seem to work right when loading the box at first. need to enter viewer mode and then return to
• overloading dirt / underground box with clipping seems not like desired user behavior
• it may make sense to have an explicit clipping box that is created for this purpose at the same level as the underground box but a separate box
• it is invisible by default, shown with a wireframe if visible

[kfarr]

ok great progress so far:

• now you can specify geo, place a scene, and then use the "underground" layer to define your clipping area, then uncheck the visibility checkbox from underground

things to fix:

• improve logic to specify a target clipping element (the element to be clipped), right now '#google3d' id selector is hardcode
• improve logic to specify a source clipping element (the element to define clipping volume) ... such as if a street is not present, create a clipping box in the user root?
• throttle ticking, remove logging, consider removing things from tick as much as possible since this is no longer a collision component

---

Notes for testing / docs outline:

Sometimes things just get in the way. Now there's an easy way to Clip It Out!

Ingredients:

• 3DStreet Geospatial Pro
• Choose a location and enable google3d map source
• Add a street
• Click geospatial layer, open right panel, click advanced, click enableClipping
• Need more clipping? Change the size of our scene by placing objects higher or to the side. You can also place an object and toggle its visibility off.

[kfarr]

Progress notes:

• now this will look for a target of [street] and return bounding box of the first street and subelements it finds
• todo: consider throttle ticking, remove logging, consider removing things from tick as much as possible since this is no longer a collision component

Not working yet:

• if clipping is turned on, and then i turn it off during the session, it will not remove clipping and the tick appears to still run even though the component has been removed

[kfarr]

Now ready for testing / code review:

• login with geospatial pro account
• Choose a location to enable google3d map source
• Add a street
• Click geospatial layer, open right panel, click advanced, click enableClipping
• Need more clipping? Change the size of our scene by placing objects higher or to the side. You can also place an object and toggle its visibility off.

[rahulkgupta]

works!

• testing placing things higher also works. note, scaling a lightpole doesn't change the clipping box

[rahulkgupta]

mostly just questions that dont need an immediate answer

[dmarcos]

you don't need to update the clipping planes every frame. Can do similar to bounding box recalculation. Consider scenarios when you want to recalculate: rotation, scale, position changes

[dmarcos]

wrap below lines in an if statement that checks for the relevant changes that trigger a plane recalculation

    const clipPlanes = this.createPlanesFromOBB(obb);
    this.applyClippingPlanes(clipPlanes);