Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obb clipping #882

Merged
merged 15 commits into from
Oct 1, 2024
Merged

obb clipping #882

merged 15 commits into from
Oct 1, 2024

Commits on Sep 29, 2024

  1. barely working 

    enable by using console-log

document.querySelector('#clipping-box').setAttribute('obb-collider2', "clipPlaneFunction: obb;")
document.querySelector('#clipping-box').play()
    @kfarr
    kfarr committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fc2d0db View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. barely working with caveats 

    this barely works:
- you need to start a new scene
- add google 3d tiles by specifying location
- then drag and drop a new street from the add panel
- then enter viewer mode
    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ed425e7 View commit details
    Browse the repository at this point in the history

  2. remove unneeded obb-collider system elements

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f0a36cb View commit details
    Browse the repository at this point in the history

  3. super hacks

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dc1427c View commit details
    Browse the repository at this point in the history

  4. rename and delete unused code

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    840e524 View commit details
    Browse the repository at this point in the history

  5. allow specifying target 

    old behavior is still working
    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    adb04e7 View commit details
    Browse the repository at this point in the history

  6. revert data-no-pause behavior

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a730154 View commit details
    Browse the repository at this point in the history

  7. revert

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0b043ec View commit details
    Browse the repository at this point in the history

  8. use obb-clipping on 3dtiles instead of target box

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1b548d5 View commit details
    Browse the repository at this point in the history

  9. revert2

    @kfarr
    kfarr committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9d5d232 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. add enableClipping boolean to street-geo 

    can turn from false to true during session, but then setting from true to false the user must reload to see tiles without clipping.

I tried using a reduntant 'enabled' boolean on obb-clipping. that didn't work but i kept it in to test a bit more.
    @kfarr
    kfarr committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9964205 View commit details
    Browse the repository at this point in the history

  2. fix streetmix id collisions with drag-n-drop tool

    @kfarr
    kfarr committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5d186ce View commit details
    Browse the repository at this point in the history

  3. this works mind blown! 

    still might be better to have an explicit box some day -- i think there will be many case where a user will wish to have a box like this -- but this might be good enough to ship
    @kfarr
    kfarr committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    07496be View commit details
    Browse the repository at this point in the history

  4. fix toggle on/off during session

    @kfarr
    kfarr committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    80cca15 View commit details
    Browse the repository at this point in the history

  5. throttle tick for naive performance improvements 

    better solution is to monitor for pose changes on target object AND monitor for tiles loaded events from 3dtiles runtime object via threejs-loader-tiles library
    @kfarr
    kfarr committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    819233c View commit details
    Browse the repository at this point in the history