gitbook downgrade + password change clarification #327
Conversation
…that are failing the build 2) add some clarification as to the consequence of changing the root password
|
@nick3dr I don't seem to have permissions to actually assign this pr to you |
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "gitbook": "2.x.x", | |||
There was a problem hiding this comment.
This is a very different change than the issue raised at #326...
This change would require testing that I do not have time to do right now. It deserves its own PR, supported with a list of resolved issues, regressions, and test results.
There was a problem hiding this comment.
Yep, I agree, this should be in its own PR.
The issue here is that the project has never specified a gitbook version, so the build has always been picking up whatever the latest gitbook release is... so the build tools have been in constant flux with no visibility or oversight. I believe the least intrusive and safest change is actually to "freeze" the gitbook version at whatever the last successful build is (2.7.6 I think).
Before I open a different PR, are you ok with this approach?
| @@ -50,4 +50,4 @@ ssh-keygen -R 10.1.1.1 | |||
|
|
|||
| ### Security | |||
|
|
|||
| Solo's root SSH password is the same for all devices. We recommend not modifying the SSH password. Instead, improve security on your device by [changing the WiFi SSID and password](https://3drobotics.com/kb/setting-wifi-password/) via the app. | |||
| Solo's root SSH password is the same for all devices. We recommend not modifying the SSH password, as the [solo cli](starting-utils.html) will no longer be able to connect. Instead, improve security on your device by [changing the WiFi SSID and password](https://3drobotics.com/kb/setting-wifi-password/) via the app. | |||
There was a problem hiding this comment.
Surely there are other reasons too? This makes it seem like it is OK to change the SSH password if you are not using Solo CLI. I recommend listing other things that break if you know about them, and generally issuing a caution that more unknown things could/will break.
There was a problem hiding this comment.
I actually did think it'd be ok to change the root password if it weren't for the solo cli :) I'll modify the phrasing, although I'm not yet familiar enough with the overall system to have a good sense of what else might break.
|
fwiw GitbookIO/markup-it#30 should fix the gitbook issue |
fixes #326
This change is