Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitbook downgrade + password change clarification #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gitbook downgrade + password change clarification #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions book/book.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"gitbook": "2.x.x",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very different change than the issue raised at #326...

This change would require testing that I do not have time to do right now. It deserves its own PR, supported with a list of resolved issues, regressions, and test results.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I agree, this should be in its own PR.

The issue here is that the project has never specified a gitbook version, so the build has always been picking up whatever the latest gitbook release is... so the build tools have been in constant flux with no visibility or oversight. I believe the least intrusive and safest change is actually to "freeze" the gitbook version at whatever the last successful build is (2.7.6 I think).

Before I open a different PR, are you ok with this approach?

"title": "3DR Solo Development Guide",
"description": "Guide for development of hardware and software for Solo.",
"plugins":[
Expand Down
2 changes: 1 addition & 1 deletion book/starting-network.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ ssh-keygen -R 10.1.1.1

### Security

Solo's root SSH password is the same for all devices. We recommend not modifying the SSH password. Instead, improve security on your device by [changing the WiFi SSID and password](https://3drobotics.com/kb/setting-wifi-password/) via the app.
Solo's root SSH password is the same for all devices. We recommend not modifying the SSH password, as the [solo cli](starting-utils.html) will no longer be able to connect. Instead, improve security on your device by [changing the WiFi SSID and password](https://3drobotics.com/kb/setting-wifi-password/) via the app.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely there are other reasons too? This makes it seem like it is OK to change the SSH password if you are not using Solo CLI. I recommend listing other things that break if you know about them, and generally issuing a caution that more unknown things could/will break.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually did think it'd be ok to change the root password if it weren't for the solo cli :) I'll modify the phrasing, although I'm not yet familiar enough with the overall system to have a good sense of what else might break.