Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump various dependencies #78

Merged
merged 6 commits into from
Feb 14, 2022
Merged

Bump various dependencies #78

merged 6 commits into from
Feb 14, 2022

Conversation

antonagestam
Copy link
Contributor

  • Drop end-of-lifed Django versions 3.0 and 3.1.
  • Drop end-of-lifed Python 3.6 from test matrix.
  • Bump pre-commit dependencies and set pyupgrade to --py37-plus.

- Drop end-of-lifed Django versions 3.0 and 3.1.
- Drop end-of-lifed Python 3.6 from test matrix.
- Bump pre-commit dependencies and set pyupgrade to --py37-plus.
@github-actions
Copy link

github-actions bot commented Feb 14, 2022

File Coverage Lines Branches Missing
All files 94% 97% 91%
bananas/__init__.py 79% 83% 75% 19-20
bananas/models.py 98% 100% 96%
bananas/url.py 97% 100% 95%
bananas/admin/extension.py 94% 100% 88%
bananas/admin/api/i18n.py 91% 83% 100% 11
bananas/admin/api/mixins.py 72% 77% 67% 87 95-101 112 128 138-149
bananas/admin/api/serializers.py 91% 100% 83%
bananas/admin/api/versioning.py 93% 100% 87%
bananas/admin/api/views.py 99% 98% 100% 137
bananas/admin/api/schemas/base.py 91% 83% 100% 11
bananas/admin/api/schemas/yasg.py 90% 95% 86% 92 101 140-141
bananas/drf/fencing.py 91% 94% 87% 91-97 136
bananas/management/commands/syncpermissions.py 89% 95% 83% 32

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against 1dbe513

@flaeppe
Copy link
Contributor

flaeppe commented Feb 14, 2022

Nice, maybe we should try out pre-commit.ci? Since they've deprecated their github action...

@antonagestam
Copy link
Contributor Author

@flaeppe We could, but I'm a bit skeptical towards that, I think it's awesome to have everything running within Github Actions and I don't really understand the motivations for deprecating the action. I created a reusable workflow for running pre-commit that I use for phantom-types: https://github.com/less-action/reusables#pre-commit

Anyhow, whichever we pick I think we can do it separate from this PR :)

@antonagestam antonagestam marked this pull request as ready for review February 14, 2022 10:50
Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaeppe We could, but I'm a bit skeptical towards that, I think it's awesome to have everything running within Github Actions and I don't really understand the motivations for deprecating the action. I created a reusable workflow for running pre-commit that I use for phantom-types: https://github.com/less-action/reusables#pre-commit

Anyhow, whichever we pick I think we can do it separate from this PR :)

Yeah, sure. I'm merely curious really. I agree it's nicer to keep everything within GitHub actions

@flaeppe
Copy link
Contributor

flaeppe commented Feb 14, 2022

Btw, the PyPi release flow looks interesting there as well

@antonagestam
Copy link
Contributor Author

Btw, the PyPi release flow looks interesting there as well

@flaeppe Yeah it would be nice to bring something like that in here, makes it super-easy to build and publish releases, by just creating a release on Github 🙂

@antonagestam antonagestam merged commit 39bdc99 into master Feb 14, 2022
@antonagestam antonagestam deleted the fix/bump-test-matrix branch February 14, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants