Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

84-homework-student-feature-use-the-saved-completions-time-to-generate-stats-and-averages #92

Conversation

AllanVester
Copy link
Contributor

@AllanVester AllanVester commented Nov 26, 2024

Description

A new button has been added to the dashboard. This button, when clicked, shows the user a series of stats. These are calculated using the database whenever block_homework is loaded. It also calculates the user's reading speed, in minutes per page, and then it uses this to estimate the time needed for anything with a page count. Video times are also used for estimates. The reading speed is based on a default of 2 minutes per page, with the user's statistics gradually influencing it, weighted such that after 3 hours, the user's speed becomes more important than the default.

The estimates are shown for each material when clicking "time", but they are also shown for the entire homework instance.

Walkthrough

As long as you have any homework available, you can see the estimate on the dashboard and by clicking time.

Dashboard:
image

Time:
image

The stats page will have every stat at 0 unless you have at least one completion.
image

…ime-to-generate-stats-and-averages' of https://github.com/AAU-P5-Moodle/moodle-2 into 84-homework-student-feature-use-the-saved-completions-time-to-generate-stats-and-averages
…eature-use-the-saved-completions-time-to-generate-stats-and-averages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda silly to not update the version to the date of when changes were implemented

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ændret

Copy link
Contributor

@Verdoner Verdoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems as if I can not have a 100% completion even though I have no more unfinished homework.

image

If this is an issue on my end then nevermind.
The rest looks good.

@sinagaming69
Copy link
Contributor

It seems as if I can not have a 100% completion even though I have no more unfinished homework.

image

If this is an issue on my end then nevermind. The rest looks good.

Vil du dele præcis hvilke homework materials og completions der var, for at den fejl dukker op? Vi kan ikke genskabe den

@Verdoner
Copy link
Contributor

Here you can see the homeworks I have:
image

The material associated with that homework:
image

Which materials are marked as completed:
image

From this information it would seem to me that the file associated to the homework with id = 1 is not completed, yet I have no option of actually completing it as seem here:

image

@sinagaming69
Copy link
Contributor

sinagaming69 commented Nov 27, 2024

Vi kan se fejlen. Det sker i get_infohomework_modal. Det er fordi den kode, der deler lektier op i literature, link eller video, for at tildele dem ikoner, jo så ender med at skippe de lektier, der ikke passer ind i nogen af de tre kategorier. Ved ikke om det så skal laves som en bugfix, da der skulle laves en hel tredje kategori i forhold til ikoner osv. og det jo ikke er en bug ved det vi har lavet nu

…the-saved-completions-time-to-generate-stats-and-averages' into 84-homework-student-feature-use-the-saved-completions-time-to-generate-stats-and-averages
@Verdoner
Copy link
Contributor

Hvis det ikke har noget med jeres opgave at gøre, så tænker jeg ikke umiddelbart at det er noget i skal fikse nu (medmindre i har lyst). Jeg ville nok oprette et nyt issue med det i stedet.

@Verdoner Verdoner self-requested a review November 27, 2024 13:27
@AllanVester AllanVester merged commit 306ea75 into main Nov 27, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Homework-Student-Feature] Use the saved completions time to generate stats and averages
3 participants