Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1deg_jra55_ryf_bgc configuration #60

Merged
merged 10 commits into from
Apr 8, 2024

Conversation

dougiesquire
Copy link
Collaborator

Update 1deg_jra55_ryf_bgc configuration from COSIMA to ACCESS-NRI format. Related #19

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Just a few things to fix.

config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
metadata.yaml Show resolved Hide resolved
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougiesquire
Copy link
Collaborator Author

Oops, my commits aren't signed. Want me to rebase, or are you okay to merge?

@dougiesquire
Copy link
Collaborator Author

I promise it me, Douglas Square

@aidanheerdegen
Copy link
Member

All good. I'll merge.

@aidanheerdegen aidanheerdegen merged commit c54fa8f into dev-1deg_jra55_ryf_bgc Apr 8, 2024
8 checks passed
This was referenced Apr 8, 2024
@CodeGat CodeGat deleted the update-1deg_jra55_ryf_bgc branch June 19, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants