Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!test Comment Command #73

Merged
merged 18 commits into from
Oct 17, 2024
Merged

!test Comment Command #73

merged 18 commits into from
Oct 17, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Oct 7, 2024 •
edited
Loading

Add a !test repro [commit] command to allow commenters to commit and compare repro runs that aren't on release-* branches.

In this PR:

  • Add config-comment-repro.yml workflow for repro tests on any branch!
  • Added ability to commit the result of the repro test to the PR

Closes #38

@CodeGat CodeGat added priority:high type:feature type:infra Dealing with CI/CD Pipelines labels Oct 7, 2024
@CodeGat CodeGat self-assigned this Oct 7, 2024
@CodeGat CodeGat marked this pull request as draft October 7, 2024 01:56
@CodeGat CodeGat mentioned this pull request Oct 9, 2024
Closed
@CodeGat CodeGat changed the title !repro Comment Command !test Comment Command Oct 9, 2024
@CodeGat CodeGat marked this pull request as ready for review October 17, 2024 01:11
@CodeGat CodeGat mentioned this pull request Oct 17, 2024
Merged
aidanheerdegen
aidanheerdegen requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

I note that "just add a the ability to run repro test through ChatOps" ends up being a lot more complicated than I realised. Sorry about that!

.github/workflows/config-comment-test.yml Outdated Show resolved Hide resolved
.github/workflows/config-comment-test.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
.github/workflows/config-comment-test.yml Show resolved Hide resolved
.github/workflows/config-comment-test.yml Show resolved Hide resolved
.github/workflows/config-comment-test.yml Show resolved Hide resolved
aidanheerdegen
aidanheerdegen approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@CodeGat CodeGat merged commit cac6a39 into main Oct 17, 2024
@CodeGat CodeGat deleted the repro-comment-command branch October 17, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
priority:high type:feature type:infra Dealing with CI/CD Pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Repro Checks to dev-* branches
2 participants
@CodeGat @aidanheerdegen