Allow subsetting simulation conditions in simulate_petab #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simulate_petab was mainly intended to simulate all conditions at once, but the `simulation_conditions` argument provides also an easy way to simulate only a subset of conditions. However, this currently fails, because the full parameter mapping is used an then wrong conditions are assigned. This is fixed here. Also it saved a minuscule amount of time.
plakrisenko
approved these changes
Nov 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2199 +/- ##
===========================================
+ Coverage 76.59% 77.47% +0.87%
===========================================
Files 82 82
Lines 15012 15012
===========================================
+ Hits 11499 11631 +132
+ Misses 3513 3381 -132
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simulate_petab was mainly intended to simulate all conditions at once, but the
simulation_conditionsargument provides also an easy way to simulate only a subset of conditions. However, this currently fails, because the full parameter mapping is generated and then the wrong parameter mapping is used for the selected conditions (unless the subset matches the first N conditions of the full list).This is fixed here. Also it saves a minuscule amount of time.