Fix SUNContext in ModelStateDerived copy ctor
#2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweindl
changed the title
When copying SUNDIALS objects, we need to make sure they have a valid `SUNContext` set. When copying `ModelStateDerived`, the `SUNContext` needs to be updated. Otherwise, dangling SUNContext pointers likely result in segfaults later on (AMICI-dev#2579). This was done only for a subset of objects. In particular the ones added only during AMICI-dev#2505 were missing, because of other changes happening in parallel. To make this less messy: Add `set_ctx(.)` functions all our sundials vector/matrix wrappers. Closes AMICI-dev#2579.
Merged
dweindl
changed the title
SUNContext in ModelStateDerived copy ctor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2583 +/- ##
===========================================
+ Coverage 77.76% 77.83% +0.07%
===========================================
Files 325 325
Lines 21862 21852 -10
Branches 1473 1456 -17
===========================================
+ Hits 17000 17008 +8
+ Misses 4835 4833 -2
+ Partials 27 11 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying SUNDIALS objects, we need to make sure they have a valid
SUNContextset. When copyingModelStateDerived, theSUNContextneeds to be updated. Otherwise, danglingSUNContextpointers likely result in segfaults later on (#2579).This was done only for a subset of objects. In particular the ones added only during #2505 were missing, because of other changes happening in parallel.
To make this less messy: Add
set_ctx(.)functions all our sundials vector/matrix wrappers.Closes #2579.