Add RDataReporting::observables_likelihood
#2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RDataReporting::observables_likelihood for computing observables, likelihood and the respective sensitivities. Closes AMICI-dev#2625. Fixes allocating sllh despite SensitivityMethod::none.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2627 +/- ##
===========================================
- Coverage 77.05% 77.03% -0.02%
===========================================
Files 332 332
Lines 22957 22970 +13
Branches 1477 1478 +1
===========================================
+ Hits 17689 17695 +6
- Misses 5257 5264 +7
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Dec 16, 2024
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Dec 19, 2024
Fixes AMICI-dev#2627. ReturnData.sllh was always NaN because it wasn't 0-initialized.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Fixes #2627. ReturnData.sllh was always NaN because it wasn't 0-initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RDataReporting::observables_likelihoodfor computing observables, likelihood and the respective sensitivities. Closes #2625.Fixes allocating
ReturnData::sllhdespiteSensitivityMethod::none.