[WIP] lower ode_max_steps and make burn retry on by default #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
experience with science problems has shown that, especially on GPUs, one zone can take ode_max_steps and then fail, forcing the application code to deal with it (e.g. Castro retries). But often using the burn retry functionality (in particular swapping the Jacobian) makes the zone pass. This change lowers ode_max_steps from 150000 to 25000 and turns on the retry (which only enables Jacobian swapping by default). This should help with a lot of applications, although lowering ode_max_steps more can help further.
zingale
changed the title
|
closes #1634 |
|
Castro test suite seems to run fine with this change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experience with science problems has shown that, especially on GPUs, one zone can take ode_max_steps and then fail, forcing the application code to deal with it (e.g. Castro retries). But often using the burn retry functionality (in particular swapping the Jacobian) makes the zone pass.
This change lowers ode_max_steps from 150000 to 25000 and turns on the retry (which only enables Jacobian swapping by default). This should help with a lot of applications, although lowering ode_max_steps more can help further.