Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] lower ode_max_steps and make burn retry on by default #1638

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

[WIP] lower ode_max_steps and make burn retry on by default #1638

wants to merge 1 commit into from

Commits on Jul 31, 2024

  1. lower ode_max_steps and make burn retry on by default 

    experience with science problems has shown that, especially on GPUs,
one zone can take ode_max_steps and then fail, forcing the application
code to deal with it (e.g. Castro retries).  But often using the
burn retry functionality (in particular swapping the Jacobian)
makes the zone pass.

This change lowers ode_max_steps from 150000 to 25000 and turns
on the retry (which only enables Jacobian swapping by default).
This should help with a lot of applications, although lowering
ode_max_steps more can help further.
    @zingale
    zingale committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a97fc2c View commit details
    Browse the repository at this point in the history