Fix bad performance with passthroughblocks #708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,27 +118,30 @@ public void doUpdate() { | |||
| validExterior.addAll(hitBox.difference(craft.getHitBox())); | |||
| } | |||
| //Check to see which locations in the from set are actually outside of the craft | |||
| SetHitBox visited = new SetHitBox(); | |||
| for (MovecraftLocation location : validExterior) { | |||
| if (craft.getHitBox().contains(location) || exterior.contains(location)) { | |||
There was a problem hiding this comment.
Is exterior.contains(location) not redundant? exterior will now only be populated after the loop finishes, as exterior.addAll(visited) was moved outside of it.
There was a problem hiding this comment.
ya that looks redundant to me
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
As discussed on discord, this moves the creation of visited in front of the loop and addAll of exterior to after the loop
Checklist