Add aarch64 library variants for no-unaligned-access #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces new library variants for aarch64 to support targets where unaligned memory accesses are disabled. To enable these changes a patch to picolibc was required, ensuring the assembly implemenation that relies on unaligned accesses is not used when `__ARM_FEATURE_UNALIGNED` is not defined.
simpal01
approved these changes
Nov 18, 2024
simpal01
added a commit
to simpal01/LLVM-embedded-toolchain-for-Arm
that referenced
this pull request
Nov 18, 2024
I had changes in CMakeLists.txt to use the correct bootcode. This is no longer needed as it is already adding through a different patch: ARM-software#567
|
Abandoning this PR in favour of #572. |
simpal01
added a commit
that referenced
this pull request
Nov 26, 2024
This introduces new library variants for aarch64 to support targets where unaligned memory accesses are disabled. To enable these changes a patch to picolibc was required, ensuring the assembly implemenation that relies on unaligned accesses is not used when __ARM_FEATURE_UNALIGNED is not defined. Co-authored by: @pratlucas ( (#567) --------- Co-authored-by: Lucas Prates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces new library variants for aarch64 to support targets
where unaligned memory accesses are disabled.
To enable these changes a patch to picolibc was required, ensuring the
assembly implemenation that relies on unaligned accesses is not used
when
__ARM_FEATURE_UNALIGNEDis not defined.