Feature/499 Fix SWIG Eigen type maps to remove data leaks #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-g-bonilla
changed the title
juan-g-bonilla
changed the title
schaubh
previously requested changes
Nov 19, 2023
There was a problem hiding this comment.
All the scenario unit tests are now failing in the branch?
Hold on, trying another branch an all scenario test files are failing there as well. Might be something odd on my system.
Ok, it was a python caching thing that was causing these error. I'll pull your branch later today and try again. Sorry for the false alarm.
schaubh
force-pushed
the
feature/499-fix-leaks-swig-typemaps
branch
from
0630b20 to
beb7158
Compare
schaubh
dismissed
their stale review
Issues were on my system, not with the branch.
|
Looks good to me. Will run some tests in the next couple weeks to see what other leaks remain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Py_DECREFwhen necessary to ensure no data leaks are happening.Verification
Existing tests are passing, and @Mark2000 reported less leaks on testing.