Remove bskSim depreciated code #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bskSim simulations were still providing access to variables with 'Wrap' at the end of the variable in case other simulations where using this. Now only the new C module naming convention is used.
The style file `sphinx_rtd_theme` we use is not yet compatible with sphinx 8.x.
Mark2000
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
bskSimcode contained depreciated variable naming for backwards compatibility.The depreciation period ended July 30, 2024. This old code is now being removed.
Verification
Did a clean build of the documentation which worked as expected. But, the documentation can't use the very recent
sphinxtool version 8.x as thesphinx_rtd_themestyle file is not yet compatible with this.Documentation
Updated the optional package install requirements that
sphinx8.x is not yet supported.Future work
None