Feature/743 solar array reference fix #885
Merged
+49
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcalaon
force-pushed
the
feature/743-solarArrayReference-fix
branch
2 times, most recently
from
2a09d0f to
3b61a2e
Compare
schaubh
requested changes
Dec 28, 2024
src/fswAlgorithms/effectorInterfaces/solarArrayReference/solarArrayReference.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/solarArrayReference/solarArrayReference.h
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/solarArrayReference/_UnitTest/test_solarArrayReference.py
Outdated
Show resolved
Hide resolved
rcalaon
force-pushed
the
feature/743-solarArrayReference-fix
branch
2 times, most recently
from
1239f03 to
e7b6d42
Compare
rcalaon
force-pushed
the
feature/743-solarArrayReference-fix
branch
2 times, most recently
from
392a259 to
386e653
Compare
rcalaon
force-pushed
the
feature/743-solarArrayReference-fix
branch
from
386e653 to
1825747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a model error introduced with the previous update to the
solarArrayReferencemodule. The error consisted in assuming that the power-generating surface of the arrays was reflective. The surface is, in fact, mostly absorbent, and this changes the guidance model.The momentum management mode of the module is changed according to a new guidance law that reflects a more accurate model. The first commit contains changes to the module code, the second and third commit reflect the updates to the unit test and the documentation, respectively.
Verification
The unit test is updated to reflect the changes in the model.
Documentation
The documentation is updated to reflect the changes in the model.
Future work
Reference to the journal paper is going to be added to the documentation once this is published.