-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to use Availability
attribute
#80
Update code to use Availability
attribute
#80
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
============================================
+ Coverage 78.33% 79.01% +0.68%
- Complexity 529 548 +19
============================================
Files 86 87 +1
Lines 1620 1687 +67
Branches 159 169 +10
============================================
+ Hits 1269 1333 +64
- Misses 320 321 +1
- Partials 31 33 +2 ☔ View full report in Codecov by Sentry. |
Set<Availability> availabilityList = | ||
ParserUtil.parseAvailabilities(argMultimap.getAllValues(PREFIX_AVAILABILITY)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current default behaviour if the the user types nothing for availability, the availability is listed as none of the days, rather than any or all of the days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that behaviour is intuitive imo, as opposed to the alternative be that availability be defaulted to all the days
Possible future implementation idea: user can type a/ALL
and system parses it as the 7 days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Though not to sure if our original intended intention is to have availability be (None of the days) empty if the user types nothing. Others may chip in on what they think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Closes #5, closes #66
Availability
data field toPerson
modeladd
andedit
) to useAvailability
Availability
data toSampleDataUtil
Availability
Availability
dataAvailability
in the application