Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exclude src/test and website from python wheel sdist #1857

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

cary-ilm
Copy link
Member

@cary-ilm cary-ilm commented Oct 1, 2024

The source should appear in the sdist, since the build's cmake requires them.

The source should appear in the sdist, since the build's cmake requires them.

Signed-off-by: Cary Phillips <[email protected]>
@JeanChristopheMorinPerso
Copy link
Member

Is website absolutely necessary? I'm not too sure why cmake would need it considering that we use components.

@cary-ilm
Copy link
Member Author

cary-ilm commented Oct 2, 2024

The build compiles the example source code in website/src to verify that it compiles. This could stand to get straightened out a bit.

@cary-ilm cary-ilm merged commit 26fc443 into AcademySoftwareFoundation:main Oct 6, 2024
34 checks passed
cary-ilm added a commit that referenced this pull request Oct 6, 2024
The source should appear in the sdist, since the build's cmake requires them.

Signed-off-by: Cary Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants