Add PHP 8.4 to GitHub Actions test matrix #11
Conversation
This update includes PHP 8.4 in the matrix of PHP versions used for testing in the GitHub Actions workflow. The addition ensures that the project's code is tested against the latest PHP version, enhancing compatibility and stability.
WalkthroughThe changes involve an update to the GitHub Actions workflow configuration in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/test.yml (1)
37-37: Consider separating experimental PHP versionsFor better organization and clarity, consider:
- Moving PHP 8.4 to a separate experimental job
- Adding appropriate labels/badges to indicate experimental status
Here's a suggested approach:
static-analysis: name: Static Analysis runs-on: ubuntu-22.04 strategy: matrix: - php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ] + php-versions: [ '8.0', '8.1', '8.2', '8.3' ] + static-analysis-experimental: + name: Static Analysis (Experimental) + runs-on: ubuntu-22.04 + continue-on-error: true + strategy: + matrix: + php-versions: [ '8.4' ]
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-22.04 | |||
| strategy: | |||
| matrix: | |||
| php-versions: [ '8.0', '8.1', '8.2', '8.3' ] | |||
| php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ] | |||
There was a problem hiding this comment.
💡 Codebase verification
Add continue-on-error for PHP 8.4 to handle potential incompatibilities
While composer.json allows PHP versions >=8.0 and no explicit conflicts were found in dependencies, PHP 8.4 is still in alpha stage. To prevent potential CI failures from blocking PRs while maintaining early testing:
strategy:
matrix:
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
include:
- php-versions: '8.4'
continue-on-error: true🔗 Analysis chain
Consider handling PHP 8.4 as an experimental build
PHP 8.4 is currently in alpha stage and not ready for production use. While it's great to test against upcoming versions, consider:
- Adding
continue-on-error: truefor PHP 8.4 to prevent CI failures from blocking PRs - Verifying composer.json PHP version constraints
Let's check the composer.json configuration:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check PHP version constraints in composer.json and potential compatibility issues
# Check composer.json PHP version constraints
echo "Checking composer.json PHP version constraints:"
if [ -f "composer.json" ]; then
cat composer.json | jq -r '.require.php'
fi
# Check if any dependencies explicitly exclude PHP 8.4
echo "Checking dependencies that might conflict with PHP 8.4:"
if [ -f "composer.lock" ]; then
cat composer.lock | jq -r '.packages[] | select(.require.php != null) | {name: .name, php: .require.php}'
fi
Length of output: 326
This update includes PHP 8.4 in the matrix of PHP versions used for testing in the GitHub Actions workflow. The addition ensures that the project's code is tested against the latest PHP version, enhancing compatibility and stability.
Summary by CodeRabbit