Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 to GitHub Actions test matrix #11

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add PHP 8.4 to GitHub Actions test matrix #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php-versions: [ '8.0', '8.1', '8.2', '8.3' ]
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Add continue-on-error for PHP 8.4 to handle potential incompatibilities

While composer.json allows PHP versions >=8.0 and no explicit conflicts were found in dependencies, PHP 8.4 is still in alpha stage. To prevent potential CI failures from blocking PRs while maintaining early testing:

strategy:
  matrix:
    php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
  include:
    - php-versions: '8.4'
      continue-on-error: true
🔗 Analysis chain

Consider handling PHP 8.4 as an experimental build

PHP 8.4 is currently in alpha stage and not ready for production use. While it's great to test against upcoming versions, consider:

  1. Adding continue-on-error: true for PHP 8.4 to prevent CI failures from blocking PRs
  2. Verifying composer.json PHP version constraints

Let's check the composer.json configuration:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check PHP version constraints in composer.json and potential compatibility issues

# Check composer.json PHP version constraints
echo "Checking composer.json PHP version constraints:"
if [ -f "composer.json" ]; then
    cat composer.json | jq -r '.require.php'
fi

# Check if any dependencies explicitly exclude PHP 8.4
echo "Checking dependencies that might conflict with PHP 8.4:"
if [ -f "composer.lock" ]; then
    cat composer.lock | jq -r '.packages[] | select(.require.php != null) | {name: .name, php: .require.php}'
fi

Length of output: 326


steps:
- uses: actions/checkout@v4
Expand All @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php-versions: [ '8.0', '8.1', '8.2', '8.3' ]
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]

steps:
- uses: actions/checkout@v4
Expand Down