Pr 5 #5
Open
Pr 5 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libgerber
reviewed
Sep 9, 2021
| return isAllUnique; | ||
| }; | ||
|
|
||
| export default isAllUniqueElements; |
There was a problem hiding this comment.
Is this line necessary? From the code I see here, I can't tell why it is needed.
dre-create
reviewed
Sep 9, 2021
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { | ||
| array.slice(currentIndex + 1).forEach((elementToCompare) => { |
There was a problem hiding this comment.
could you explain the purpose of the slice() method here?
| const isAllUniqueElements = (array) => { | ||
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { |
There was a problem hiding this comment.
Is there a way we can do this without having a nested loop?
lzhang39
reviewed
Sep 9, 2021
| const isAllUniqueElements = (array) => { | ||
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { |
There was a problem hiding this comment.
i like how each variable is descriptively named!
| @@ -0,0 +1,16 @@ | |||
|
|
|||
| const isAllUniqueElements = (array) => { | |||
| let isAllUnique = true; | |||
There was a problem hiding this comment.
perhaps change this to Var so it could be used outside the function?
GClenda
reviewed
Sep 9, 2021
| const isAllUniqueElements = (array) => { | ||
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { |
There was a problem hiding this comment.
Can we used an object instead of a loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.