Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 5 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pr 5 #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b4a2c2
is all unique elements function
CheezItMan Aug 8, 2019
429afb1
add export
CheezItMan Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions is_all_unique_elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@

const isAllUniqueElements = (array) => {
let isAllUnique = true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps change this to Var so it could be used outside the function?


array.forEach((currentElement, currentIndex) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like how each variable is descriptively named!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops ignore, was thinking in Swift

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we used an object instead of a loop?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can do this without having a nested loop?

array.slice(currentIndex + 1).forEach((elementToCompare) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain the purpose of the slice() method here?

if (elementToCompare === currentElement) {
isAllUnique = false;
}
});
});

return isAllUnique;
};

export default isAllUniqueElements;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line necessary? From the code I see here, I can't tell why it is needed.