Tunes Takeout #23
Open
Tunes Takeout #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 16, 2016 15:46
…Spotify API. Wraps interactions with the Spotify API by leveraging the RSpotify gem
… with all the acurate atributes
added 13 commits
May 21, 2016 16:32
…s in theto reach Charles API and delete that fav
… the user test is not set
| redirect_to root_path | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Minor, but you can clean up whitespace.
|
Good work Melissa! You code was easy to follow and read. I like that it was not complicated at all! I used to think that a lot of code + more complicated = better. But now that I'm reviewing a lot of code now, I know that simple and easy to read is better! Good job! Good work in keeping logic out of the views too. One thing that takes time getting used to is indentation and eliminating white space. That's something you can work on, and it just takes seeing it a lot more to get used to it. Easy! YAYYY GOOD WORK! |
|
Thanks @annaleeherrera for all the feedback!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you miss me? I was in the wrong repo!