forked from AdaGold/tunes-takeout
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tunes Takeout #23
Open
meliquintero
wants to merge
74
commits into
Ada-C5:master
Choose a base branch
from
meliquintero:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tunes Takeout #23
Changes from 70 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
bca2955
added gems Spotity and Yelp API's, HTTParty, simplecov and pry-rails
f3ae0d6
bundle
8f2ef30
created controllers and its actions from the command line
e85bfde
more files auto generated for the controllers
ae4e3af
generate the models from the command line
61d8e1a
TunesTakeoutWrapper and added to the libs folder
902ce31
made the conection with the file in lib
7bbabc4
Made possible print the data from Tunes Api on the suggestions view
8a26d83
A plain Ruby object that receives and models data retrieved from the …
5cae683
have the Yelp API working
9863e94
added all the gems necesary for the user authentication with Stofify
e2f3f9b
bundle
be32b42
pulished the model to create the Music and the Food Objects properly,…
ed02bde
hide the files with sensitive conteent such as my Yelp and Spotify keys
5d084c8
added routes for user autentucation
d743250
created helper methods current_user and login?
4a5b550
created migrations to set the User attributes
628a8b9
started implementing omniauth
5476257
User authentication with Spotofy works... for now
bb23d43
fixed bug for spanish words
1fdc060
styles, more refactor
bc20d57
fixed bug, doubble looping
28af326
crated method for the top 20
2e05ffe
error
a3b9a1c
style
4ac1b47
css sugar, spotofy play
ee4165b
set Simplecov
5105b60
fixed the way top favorites where reachin into Charles API to get Spo…
57a72be
created partial to display list of suggestions
7cc2b51
started with the add favorite request
629485b
added some style, detele squile 3 gem
58ff99e
copy pasta the database.yml file back with the PG info
b6fac32
think the add favorites works
c6f8430
added the head part of the post request, now the add favorite works, …
46798e3
redisingeded the routes to meet with the requirements
0b1510e
started to fetch my favos
1440bba
moved the search bar to the nav bar
97342eb
change the background
bb552c1
my favorites ready to go
da39874
added filters to suggestions controllers
526d377
added telephone and open in yelp url
702608d
added links to open in Spotofy and yelp to respective images and names
32bbf5a
changed the home button and added a favicon
3f63be9
added telephone number and link to call from comuter or mobite
eed652a
added the pics from favicon
212acc5
happy (for now) with the style
3584678
change the displaed title
3c297b1
very proud of the refactoring this controller, I integrated three loo…
24e8c8a
added the sybol '=' so the user name would show upgit add app/views/s…
9024f61
more little details
4778d2f
add colunm URL to the user table, so the schema changed
8d7a115
now the schema did change for realgit add db/schema.rbgit add db/sche…
05a92be
captured the open in Spotify from API
f8b9eba
added links open in Spotify to the user name and picture , moved that…
f1d0410
added the method search_result to the filter
4ce3bc3
change the par_ia _display l name to match the instructions to _sugg…
dd47f8b
added the delete route for unfavorite
0e5478c
created (copy and pasta from the add_favorite and replace )the method…
ee6f0a8
added (copy and pasta the fav buttun) the unfav button to the patial
7de1025
double check the gems need for testing
8a51c97
got rid of the playlist edge pase
76009c3
a 100% coverage user test
4712204
added two files to the Simplecov filters
5009165
fixed the test for suggestions controller, still throing errors since…
a8124e3
change the delete test. But User test no ready yet
f480cdd
100% Food.rb test coverage
1592e49
added the add bottun eventhough the name and pictures are clickable t…
c5b5b13
tried thigs around with User for testing
5e287aa
trying out some test
eea2052
added gem in the Production group
09451bb
took yelp.rb aout of the .gitignore
620423b
made the login statment to the right
13e0239
details on the music display
81a2ec8
deleted commets
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// Place all the styles related to the sessions controller here. | ||
// They will automatically be included in application.css. | ||
// You can use Sass (SCSS) here: http://sass-lang.com/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// Place all the styles related to the suggestions controller here. | ||
// They will automatically be included in application.css. | ||
// You can use Sass (SCSS) here: http://sass-lang.com/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but you can clean up whitespace.