[ECP-9605] Fix broken Magento 2.4.4 and 2.4.5 compatibility #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
changed the title
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
|
khushboo-singhvi
approved these changes
Feb 5, 2025
amihajlovski
approved these changes
Feb 5, 2025
zenit2001
approved these changes
Feb 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though PHP 8 supports mix method return types, Magento 2 does not support it and throws exception while compiling the generated files on 2.4.4 and 2.4.5. This PR replaces the mix return types with single return types.
Besides that, Magento 2.4.4 compatibility is broken due to the required version of
magento/module-instant-purchaseon #2828. The required version has been downgraded to support Magento 2.4.4 and 2.4.5.Tested scenarios
Fixes #2870