-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: complete UndelegateAndTransfer and DepositAndDelegate flows
#10045
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d4aa0ea
feat: narrow AmountArg to NatAmountShape
0xpatrickdev 6420537
feat!: `undelegate` takes AmountArg and ChainAddress
0xpatrickdev 73404f2
feat: complete undelegateAndTransfer flow
0xpatrickdev cfe73bc
feat: delegate allows any bondDenom
0xpatrickdev 5415202
refactor: initChain -> registerChain
0xpatrickdev 06703a5
feat: complete `depositAndDelegate` flow
0xpatrickdev 0107842
docs: staking-combinations USAGE
0xpatrickdev 07fcaba
types: GuestInterface supports synchronous returns
0xpatrickdev 2a50005
chore: update retry timeouts
0xpatrickdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,73 @@ | ||
| import { expectType } from 'tsd'; | ||
| import type { Zone } from '@agoric/base-zone'; | ||
| import type { Vow, VowTools } from '@agoric/vow'; | ||
| import type { HostOf, GuestOf } from '../src/types.js'; | ||
| import type { | ||
| HostOf, | ||
| GuestOf, | ||
| HostInterface, | ||
| GuestInterface, | ||
| } from '../src/types.js'; | ||
|
|
||
| const castable: unknown = null; | ||
| const vt: VowTools = null as any; | ||
|
|
||
| const sumVow = (a: number, b: number) => vt.asVow(() => a + b); | ||
|
|
||
| const sumPromise = (a: number, b: number) => Promise.resolve(a + b); | ||
|
|
||
| expectType<(p1: number, p2: number) => Promise<number>>( | ||
| null as unknown as GuestOf<typeof sumVow>, | ||
| castable as GuestOf<typeof sumVow>, | ||
| ); | ||
|
|
||
| expectType<(p1: number, p2: number) => Vow<number>>( | ||
| null as unknown as HostOf<typeof sumPromise>, | ||
| castable as HostOf<typeof sumPromise>, | ||
| ); | ||
| expectType<(p1: number, p2: number) => Vow<void>>( | ||
| // @ts-expect-error incompatible return type | ||
| null as unknown as HostOf<typeof sumPromise>, | ||
| castable as HostOf<typeof sumPromise>, | ||
| ); | ||
|
|
||
| // Test HostInterface and GuestInterface with an exoClass object | ||
| type ExoAPIBase = { | ||
| getValue: () => number; | ||
| setValue: (value: number) => void; | ||
| getCopyData: () => Record<string, number>[]; | ||
| // TODO include `getRemote() => Guarded<...>`, since durable exos are passable | ||
| }; | ||
| type ExoGuestAPI = ExoAPIBase & { | ||
| getValueAsync: () => Promise<number>; | ||
| }; | ||
|
|
||
| type ExoHostAPI = ExoAPIBase & { | ||
| getValueAsync: () => Vow<number>; | ||
| }; | ||
|
|
||
| expectType< | ||
| ExoAPIBase & { | ||
| getValueAsync: () => Vow<number>; | ||
| } | ||
| >(castable as HostInterface<ExoGuestAPI>); | ||
| expectType< | ||
| ExoAPIBase & { | ||
| getValueAsync: () => Promise<number>; | ||
| } | ||
| >(castable as GuestInterface<ExoHostAPI>); | ||
|
|
||
| // Test HostInterface and GuestInterface with classKit (nested) objects | ||
| expectType<{ | ||
| facet: ExoAPIBase & { | ||
| getValueAsync: () => Vow<number>; | ||
| }; | ||
| }>( | ||
| castable as HostInterface<{ | ||
| facet: ExoGuestAPI; | ||
| }>, | ||
| ); | ||
| expectType<{ | ||
| facet: ExoAPIBase & { | ||
| getValueAsync: () => Promise<number>; | ||
| }; | ||
| }>( | ||
| castable as GuestInterface<{ | ||
| facet: ExoHostAPI; | ||
| }>, | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉