feat: complete UndelegateAndTransfer and DepositAndDelegate flows

[0xpatrickdev]

closes: #10046

Description

• use AnyNatAmountShape for AmountArg in @agoric/orchestration
• Update undelegate to take AmountArg and ChainAddress
• Update undelegate to accept and bondDenom
• Finish UnelegateAndTransfer and DepositAndDelegate flows in staking-combinations contract

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

Updates existing tests and includes tests for new functionality

Upgrade Considerations

n/a

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	2a50005
Status:	✅  Deploy successful!
Preview URL:	https://a8bbd1e7.agoric-sdk.pages.dev
Branch Preview URL:	https://pc-staking-combinations.agoric-sdk.pages.dev

View logs

[github-actions]

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

[turadg]

Isn' this just:

Suggested change

	: T[K] extends (...args: any[]) => infer R
	? (...args: Parameters<T[K]>) => R
	: T[K] extends (...args: any[]) => infer R
	? T[K]

I don't think that's quite right though. What failure did you run into? Please add the cases to async-flow/test/types.test-d.ts so we can avoid regressions in these types.

[0xpatrickdev]

Thanks, this is simpler and works. The error I was seeing was: Type 'GuestInterface<() => HostInterface<ChainAddress>>' has no call signatures.

I added a type test in f10bad5.

I was expecting to be able to do:

@@ -1,5 +1,6 @@
 import { expectType } from 'tsd';
 import type { Vow, VowTools } from '@agoric/vow';
+import type { Guarded } from '@endo/exo';
 import type {
   HostOf,
   GuestOf,
@@ -30,6 +31,7 @@ type ExoAPIBase = {
   getValue: () => number;
   setValue: (value: number) => void;
   getCopyData: () => Record<string, number>[];
+  getRemote: () => Guarded<{ doFoo: () => void }>;
 };
 type ExoGuestAPI = ExoAPIBase & {
   getValueAsync: () => Promise<number>;

But see:

Type 'HostInterface<Guarded<{ doFoo: () => void; }>>' is missing the following properties from type 'RemotableBrand<{}, { doFoo: () => void; } & GetInterfaceGuard<{ doFoo: () => void; }>>': L, R

Is Guarded the correct way to type a durable remotable?

[turadg]

Hmm, Guarded should:

export type Farable<M extends Methods> = M &
  RemotableBrand<{}, M> &
  RemotableObject;
export type Guarded<M extends Methods> = Farable<M & GetInterfaceGuard<M>>;

but RemotableBrand expects these private properties,

export declare class RemotableBrand<Local, Remote> {
  /** The local properties of the object. */
  private L: Local;

  /** The type of all the remotely-callable functions. */
  private R: Remote;
}

I suppose we need to fix RemotableBrand so it doesn't appear to have L and R as real properties. WDYT @michaelfig ?

Meanwhile I think it's okay to cast or expect error with an explanation

[michaelfig]

Please don't change RemotableBrand... it's carefully tuned to give proper errors when you pass it an object that wasn't created correctly as a Remotable. Consider it an internal type that makes E work with things like Exo-objects, Remotable, Far, and durables, not for use outside that layer.

To me, it seems that HostInterface is at fault; it needs to explicitly handle any RemotableBrand that was implied by its template parameter.

[michaelfig]

Isn't this just:

Not the same, but I'm not sure what was intended.

The more complex version returned the type of just the function itself (such as the type of a simple wrapper function), but the "simpler" version preserved the type of the function including all the subproperties that might be hanging off of it.

[0xpatrickdev]

Meanwhile I think it's okay to cast or expect error with an explanation

I just left a TODO for now

but I'm not sure what was intended

The changes were to support: getChainAddress: () => ChainAddress

[turadg]

🎉

[turadg]

ty

[turadg]

better name. I forget why we had init before. Maybe thinking it would be only allowed once? but clearly what it's doing is registering