Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): publish a3p-use-upgrade-next #10083

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelfig
Copy link
Member

closes: #XXXX
refs: #XXXX

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@michaelfig michaelfig self-assigned this Sep 12, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 12, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e67c2e
Status: ✅  Deploy successful!
Preview URL: https://bb7b0725.agoric-sdk.pages.dev
Branch Preview URL: https://mfig-docker-use-upgrade-next.agoric-sdk.pages.dev

View logs

# These tags don't have an image name attached yet and are JSONified
# with newline separators because they are used as input to
# docker/metadata-action.
PREFIX=a3p-use-upgrade-next-
Copy link
Member

@turadg turadg Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image needs to be separate from agoric-sdk. We've already had people burn effort thinking agoric-sdk:a3p-use-upgrade-next-20240911203722-bc66a5 gives you an agoric-sdk.

some alternatives:

I like the latter because the relationship with agoric-sdk is clear

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter is fine.

Base automatically changed from mfig-docker-depot to master September 13, 2024 21:41
Copy link

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants