A3P commands without synthetic-chain #10396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
2740748
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://efbbdff5.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10369-skip-cli.agoric-sdk.pages.dev |
This comment was marked as resolved.
This comment was marked as resolved.
turadg
force-pushed
the
10369-skip-cli
branch
2 times, most recently
from
0d7f011
to
9a8474a
Compare
turadg
force-pushed
the
10369-skip-cli
branch
13 times, most recently
from
1fffdcb
to
3a18e22
Compare
turadg
changed the title
turadg
force-pushed
the
10369-skip-cli
branch
4 times, most recently
from
3ea8635
to
b97d772
Compare
anilhelvaci
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Moving log from options to io makes more sense. Thanks.
anilhelvaci
reviewed
Nov 8, 2024
|
|
||
| In agoric-sdk CI and development, we want the proposals to use the versions of the packages in the agoric-sdk source tree. To accomplish this we use `yarn link`. In Yarn 4 (berry) it uses a `portal` protocol to link to another Yarn project on the filesystem. One kink is that in development the command would, | ||
| ``` | ||
| yarn link --relative ../../.. --all |
There was a problem hiding this comment.
So is this run only one time in your machine to create the resolutions in the n:upgrade-next/package.json?
|
LGTM, just asked a few small questions. I really appreciate the effort for this PR. Looking forward to seeing it support signing transactions as well. Willing to help for this if the need arises. |
anilhelvaci
approved these changes
Nov 8, 2024
turadg
force-pushed
the
10369-skip-cli
branch
4 times, most recently
from
6fdee12
to
f57d920
Compare
turadg
force-pushed
the
10369-skip-cli
branch
from
f57d920
to
2740748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10369
Description
Many of the imports from
@agoric/synthetic-chainare not about synthetics per se. They should be possible with the code in agoric-sdk.This brings the new
@agoric/client-utilsinto functional testing in a3p-integration. It makes the canonical source forsync-tool.jsthat was duplicated in different proposal tests.This also demonstrates a style of smart-wallet offer execution without the
@agoric/synthetic-chainpackage. SeeOpenVault. It still goes throughexecSwingsetTransactionspawningagdbut that could also be optimized with an RPC client lib for SwingSet that does signing (see #9200). That's out of scope for this effort to simply stop reliable in another repo for testing utilities.Review by commit is recommended
Security Considerations
n/a, tests
Scaling Considerations
n/a, tests
Documentation Considerations
When these patterns stabilize more we may want to write them down. For now I think let's keep it flexible.
Testing Considerations
per se
Upgrade Considerations
One impact to the upgrade process is that when moving a proposal from a3p-integration to agoric-3-proposals, the dependencies may have to be updated. Though it's likely they'll work on the
/usr/src/agoric-sdkin the image