A3P commands without synthetic-chain

a3p-integration/README.md

@@ -108,11 +108,37 @@ Instead of relying on an automatic `submission` folder, a core-eval proposal can
 
 # Build details
 
+In the `ghcr.io/agoric/agoric-sdk` image the filesystem is:
+```
+/usr/src/agoric-sdk
+```
+
+With the proposals layered on top of the `agoric-sdk` image, the filesystem adds (for example):
+```
+/usr/src/proposals/n:upgrade-next
+/usr/src/proposals/z:acceptance
+```
+
+In agoric-sdk CI and development, we want the proposals to use the versions of the packages in the agoric-sdk source tree. To accomplish this we use `yarn link`. In Yarn 4 (berry) it uses a `portal` protocol to link to another Yarn project on the filesystem. One kink is that in development the command would,
+```
+yarn link --relative ../../.. --all
+```
+Which configures the package.json resolutions to find agoric-sdk three levels up.
+
+But in CI the proposals aren't nested under agoric-sdk and the command would be,
+```
+yarn link --relative ../../agoric-sdk --all
+```
+
+To give a consistent location, `a3p-integration` has a symlink to the `agoric-sdk` project where the proposals expect it in the Docker fileystem. (I.e. treating `a3p-integration` as `/usr/src` of the Docker image.)
+
+
 The `yarn build` script automates 3 steps:
 - Building the `unreleased` SDK image
 - Generating the `submission` folders in core proposal packages
 - Building the synthetic-chain images using the proposals
 
+
 ## Generate a docker image with the `agoric-sdk` chain software
 
 The chain software upgrade proposal contained in this end-to-end integration test performs an upgrade of the agoric-3 synthetic chain to an `UNRELEASED_A3P_INTEGRATION` plan name (or the corresponding upgrade plan name for release branches). It loads the docker image `ghcr.io/agoric/agoric-sdk:unreleased` for the software implementing that upgrade (both in the `master` branch or in release branches).

a3p-integration/agoric-sdk

@@ -0,0 +1 @@
+../

a3p-integration/package.json

@@ -16,6 +16,6 @@
     "@agoric/synthetic-chain": "^0.3.0",
     "@types/better-sqlite3": "^7.6.11"
   },
-  "packageManager": "yarn@4.2.2",
+  "packageManager": "yarn@4.5.1",
   "license": "Apache-2.0"
 }

a3p-integration/proposals/n:upgrade-next/package.json

@@ -12,11 +12,11 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@agoric/synthetic-chain": "^0.3.0",
-    "@endo/init": "^1.1.5",
-    "@endo/marshal": "^1.5.4",
+    "@endo/init": "^1.1.6",
+    "@endo/marshal": "^1.6.1",
     "ava": "^5.3.1",
     "better-sqlite3": "^9.6.0",
-    "execa": "^9.3.1"
+    "execa": "^9.5.1"
   },
   "ava": {
     "concurrency": 1,
@@ -28,5 +28,8 @@
   "scripts": {
     "agops": "yarn --cwd /usr/src/agoric-sdk/ --silent agops"
   },
-  "packageManager": "[email protected]"
+  "packageManager": "[email protected]",
+  "devDependencies": {
+    "typescript": "^5.6.3"
+  }
 }

a3p-integration/proposals/n:upgrade-next/priceFeedUpdate.test.js

@@ -83,6 +83,7 @@ const openMarginalVault = async t => {
   const currentVaults = await agops.vaults('list', '--from', USER1ADDR);
 
   t.log('opening a vault');
+  // @ts-expect-error bad typedef
   await openVault(USER1ADDR, 5, 10);
   user1IST += 5;
   const istBalanceAfterVaultOpen = await getISTBalance(USER1ADDR);

a3p-integration/proposals/n:upgrade-next/tsconfig.json

@@ -1,12 +1,14 @@
 {
   "compilerOptions": {
-    "target": "esnext",
-    "module": "esnext",
+    "target": "ESNext",
+    "module": "NodeNext",
     "allowJs": true,
     "checkJs": true,
     "strict": false,
     "strictNullChecks": true,
     "noEmit": true,
-    "noImplicitThis": true
+    "noImplicitThis": true,
+    // XXX synthetic-chain has some errors
+    "skipLibCheck": true
   }
 }