lint error on floating promises #8198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphdev
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7888
Description
Since #8058 it's been enabled in CI. (#8061 will consolidate the two jobs into one, but that's outside the scope of this issue).
This PR enables it outside CI too (so that it always has type info and always warns on floating promisees).
Then it upgrades the warn to an error and suppresses the rule in all files that don't yet comply. It's separate work to resolve all of those: #6000.
Security Considerations
--
Scaling Considerations
--
Documentation Considerations
Notify developers of the new error and that their IDE and local lint output will no emit warnings.
Testing Considerations
CI
Upgrade Considerations
n/a